From: Luben Tuikov <ltuikov@yahoo.com>
Date: Thu, 28 Sep 2006 18:52:32 GMT
Subject: Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive
Message-ID: <20060928185232.96094.qmail@web31802.mail.mud.yahoo.com>
In-Reply-To: <20060927225342.7695.qmail@web31801.mail.mud.yahoo.com>

--- Luben Tuikov <ltuikov@yahoo.com> wrote:
> --- Junio C Hamano <junkio@cox.net> wrote:
> > Luben Tuikov <ltuikov@yahoo.com> writes:
> > 
> > > --- Jakub Narebski <jnareb@gmail.com> wrote:
> > >> I think that this need some thinking over. For blob we have two
> > >> "base" objects: tree which have specified blob, and commit which
> > >> have tree which have specified blob. We might want to specify
> > >> that all hash*base are to the commit-ish.
> > >
> > > Agreed, we should always refer to the commit-ish, for obvious
> > > reasons.
> > >
> > > This patch doesn't make this decision though.  It simply
> > > sets hash_base to HEAD if not defined.
> > >
> > > Now, since "git-ls-tree" works on both commit-ish and
> > > tree-ish, we are ok.
> > 
> > I think so, too.  Jakub?
> 
> Status?  I see Jakub hasn't objected, and it is really important
> for us to be able to link to "latest" binary blob -- for example
> a PDF spec file.

Junio,

What are the objections to this patch?

Thanks,
   Luben