From: Petr Baudis <pasky@suse.cz>
Date: Sun, 24 Sep 2006 17:48:37 GMT
Subject: Re: cg-commit -p -m ignores -p
Message-ID: <20060924174837.GX20017@pasky.or.cz>
In-Reply-To: <20060915132319.12117.qmail@7d60384c102e6d.315fe32.mid.smarden.org>

Dear diary, on Fri, Sep 15, 2006 at 03:23:19PM CEST, I got a letter
where Gerrit Pape <pape@smarden.org> said that...
> Hi, please see http:/bugs.debian.org/387515 or below.  I agree that
> ideally cg-commit should behave differently.
> 
> Thanks, Gerrit.
> 
> ----- Forwarded message from Andrew Suffield <asuffield@suffields.me.uk> -----
> 
> cg-commit -p -m ignores the -p argument and silently commits. Yes,
> this is documented, but it's still stupid behaviour; if the user had
> meant that, they would have just used -m alone.
> 
> At the very least, it should abort with an error (on the basis that
> the command makes no sense); more sensibly, it should create a log
> message with the given string and then spawn an editor (and then since
> the user will probably exit without changing the file, the "Abort or
> commit?" message would appear as per usual, which seems to me to be
> appropriate behaviour).
> 
> 
> ----- End forwarded message -----

Thanks, fixed by making cg-commit -p imply -e.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)