From: Petr Baudis <pasky@suse.cz>
Date: Fri, 22 Sep 2006 23:13:15 GMT
Subject: Re: [PATCH 4/6] gitweb: Link to associated tree from a particular log item in full log view
Message-ID: <20060922231315.GD8259@pasky.or.cz>
In-Reply-To: <7vmz8s7cvy.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Fri, Sep 22, 2006 at 06:18:09AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> I presume you are running this version at repo.or.cz, but
> 
> (1) go to http://repo.or.cz/?p=stgit.git;a=log
> (2) pick "tree" of one of the commits
> (3) go browser-back, then pick "tree" from the top navbar
> 
> The resulting tree view of (2) lacks navbar while (3) looks much
> saner.

Oops. It's trivial typo:

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index d2366c7..c5f3810 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2880,7 +2880,7 @@ sub git_log {
 		      " | " .
 		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") .
 		      " | " .
-		      $cgi->a({-href => href(action=>"tree", hash=>$commit), hash_base=>$commit}, "tree") .
+		      $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
 		      "<br/>\n" .
 		      "</div>\n" .
 		      "<i>" . esc_html($co{'author_name'}) .  " [$ad{'rfc2822'}]</i><br/>\n" .

> You do not have the tree object name available in git_log to
> generate an URL with both h and hb, and getting to it is an
> extra work.

Well using commit hash as a tree id works just fine...

> This would fix this particular breakage.

My knowledge of gitweb.perl innards isn't good enough for me to safely
ack/nak a change such deep down the chain.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)