From: Shawn Pearce Date: Mon, 18 Sep 2006 01:18:55 GMT Subject: Re: [PATCH] Contributed bash completion support for core Git tools. Message-ID: <20060918011855.GA19955@spearce.org> In-Reply-To: <7vodtex9xm.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Shawn Pearce writes: > > > Since these are completion routines only for tools shipped with > > core Git and since bash is a popular shell on many of the native > > core Git platforms (Linux, Mac OS X, Solaris, BSD) including these > > routines as part of the stock package would probably be convienent > > for many users. > > > > Signed-off-by: Shawn O. Pearce > > > > contrib/bash-git-completion.sh | 330 +++++++++++++++... > > 1 files changed, 330 insertions(+), 0 deletions(-) > > Hmph. I tried this and found that I like "git pull ." > completion quite a bit. Having said that: I got hooked very fast on the completion for git pull, git checkout and git fetch, especially on my local network where setting up the SSH connection for a remote git-ls-remote isn't that much of a performance hit. Trying to use ref completion on the Git repository itself on kernel.org was quite horrible. But it does (sort of) beat doing an ls-remote first. > * If many people like it (like me), this may deserve to be > outside contrib/ > > * Otherwise, it would probably be better to place it in either > contrib/bash/git-completion.sh (with potentially other > bash-related things not just completion, but I do not know > offhand what other kind of hooks would be useful) or > contrib/completion/git-completion.bash (possibly with > completion for other shells). I'm not sure there are too many other things to hook into bash in addition to completion so contrib/completion/git-completion.bash may be the better location, assuming it doesn't graduate out of contrib/. -- Shawn.