From: Matthias Lederhofer Date: Sun, 17 Sep 2006 11:52:45 GMT Subject: [PATCH] gitweb fix validating pg (page) parameter Message-ID: <20060917115245.GA15658@moooo.ath.cx> Currently it is possible to give any string ending with a number as page. -1 for example is quite bad (error log shows probably 100 warnings). --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 497129a..346c15c 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -259,7 +259,7 @@ if (defined $hash_parent_base) { our $page = $cgi->param('pg'); if (defined $page) { - if ($page =~ m/[^0-9]$/) { + if ($page =~ m/[^0-9]/) { die_error(undef, "Invalid page parameter"); } } -- 1.4.2.1.ge767