From: Jakub Narebski Date: Sat, 26 Aug 2006 10:33:17 GMT Subject: [PATCH 16a/19] gitweb: Remove workaround for git-diff bug fixed in f82cd3c Message-ID: <200608261233.18337.jnareb@gmail.com> In-Reply-To: <200608252113.34731.jnareb@gmail.com> Remove workaround in git_blobdiff for error in git-diff (showing reversed diff for diff of blobs), corrected in commit f82cd3c Fix "git diff blob1 blob2" showing the diff in reverse. which is post 1.4.2-rc2 commit. Signed-off-by: Jakub Narebski --- gitweb/gitweb.perl | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index e5a0db5..36a28a4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2841,8 +2841,7 @@ sub git_blobdiff { } # open patch output - #open $fd, "-|", $GIT, "diff", '-p', $hash_parent, $hash - open $fd, "-|", $GIT, "diff", '-p', $hash, $hash_parent + open $fd, "-|", $GIT, "diff", '-p', $hash_parent, $hash or die_error(undef, "Open git-diff failed"); } else { die_error('404 Not Found', "Missing one of the blob diff parameters") -- 1.4.1.1