From: Jonas Fonseca <fonseca@diku.dk>
Date: Tue, 15 Aug 2006 21:58:12 GMT
Subject: Re: [PATCH] make inline is_null_sha1 global
Message-ID: <20060815215812.GB15797@diku.dk>
In-Reply-To: <Pine.LNX.4.63.0608151335020.1475@chino.corp.google.com>

David Rientjes <rientjes@google.com> wrote Tue, Aug 15, 2006:
> diff --git a/builtin-diff.c b/builtin-diff.c
> index 82afce7..9003d55 100644
> --- a/builtin-diff.c
> +++ b/builtin-diff.c
> @@ -68,8 +68,7 @@ static void stuff_change(struct diff_opt
>  {
>  	struct diff_filespec *one, *two;
>  
> -	if (memcmp(null_sha1, old_sha1, 20) &&
> -	    memcmp(null_sha1, new_sha1, 20) &&
> +	if (is_null_sha1(old_sha1) && is_null_sha1(new_sha1) &&
>  	    !memcmp(old_sha1, new_sha1, 20))
>  		return;
>  

Looks like this should be !is_null_sha1(...) in both cases.

-- 
Jonas Fonseca