From: Luben Tuikov Date: Mon, 14 Aug 2006 02:41:46 GMT Subject: Re: [PATCH] git-commit: no silent exit on duplicate Signed-off-by lines Message-ID: <20060814024146.85979.qmail@web31807.mail.mud.yahoo.com> In-Reply-To: <7vejvlm4op.fsf@assigned-by-dhcp.cox.net> --- Junio C Hamano wrote: > Luben Tuikov writes: > > > @@ -690,7 +690,7 @@ case "$verify" in > > t) > > if test -x "$GIT_DIR"/hooks/commit-msg > > then > > - "$GIT_DIR"/hooks/commit-msg "$GIT_DIR"/COMMIT_EDITMSG || exit > > + "$GIT_DIR"/hooks/commit-msg "$GIT_DIR"/COMMIT_EDITMSG || die "Duplicate Signed-off-by lines > -- nothing commited" > > fi > > esac > > Please emit the complaint from the sample hook/commit-msg > script, not from git-commit. Ok, I will. (In which case the aforementioned patch can be dropped in favor of the new one.) Luben