From: Luben Tuikov Date: Sat, 05 Aug 2006 00:53:55 GMT Subject: Re: [PATCH 2/4] gitweb: bugfix: git_commit and git_commitdiff parents Message-ID: <20060805005355.41970.qmail@web31805.mail.mud.yahoo.com> In-Reply-To: <7vzmekgigm.fsf@assigned-by-dhcp.cox.net> --- Junio C Hamano wrote: > Luben Tuikov writes: > > > In git_commit() the hash base of $from_id is $parent, not > > $hash: > > - If status is "D", then action blob for $from_id wants > > $parent, not $hash. History needs $parent too. > > - If status is "R", then action blob for $from_id wants > > $parent, not $hash. > > > > In git_commitdiff() the hash base of $from_id is > > $hash_parent, not $hash: > > - If status is "D". > > - If status is "M". > > ... stopped in mid sentence??? Sorry. The meaning is the same as for git_commit() and as the paragraph text ("In git_commitdiff() the hash base of ..."). Luben