From: Christopher Faylor <me@cgf.cx>
Date: Wed, 28 Jun 2006 14:59:44 GMT
Subject: Re: [PATCH] git.c: Re-introduce sane error messages on missing commands.
Message-ID: <20060628145944.GB5567@trixie.casa.cgf.cx>
In-Reply-To: <20060628120044.GA3228@fiberbit.xs4all.nl>

On Wed, Jun 28, 2006 at 02:00:44PM +0200, Marco Roeland wrote:
>On Wednesday June 28th 2006 Johannes Schindelin wrote:
>
>> [PATCH] save errno in handle_alias()
>> 
>> git.c:main() relies on the value of errno being set by the last attempt to 
>> execute the command. However, if something goes awry in handle_alias(), 
>> that assumption is wrong. So restore errno before returning from 
>> handle_alias().
>
>If we rely on the value of errno we should always immediately store it's
>value anyway. On some neolithic systems like the "MSVCRT.DLL" C runtime
>library on Windows (used by e.g. the Mingw compiler, don't know about
>Cygwin) a lot of runtime functions actually even reset the value of
>errno to 0 on success!

Cygwin does not use MSVCRT.DLL and tries to be careful about spurious
resetting of errno.

cgf