From: Timo Hirvonen Date: Sun, 25 Jun 2006 11:28:19 GMT Subject: [PATCH] Don't xcalloc() struct diffstat_t Message-ID: <20060625142819.209f3519.tihirvon@gmail.com> In-Reply-To: <20060624202153.1001a66c.tihirvon@gmail.com> Signed-off-by: Timo Hirvonen --- diff.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index cc2af30..8880150 100644 --- a/diff.c +++ b/diff.c @@ -2062,17 +2062,16 @@ void diff_flush(struct diff_options *opt } if (output_format & DIFF_FORMAT_DIFFSTAT) { - struct diffstat_t *diffstat; + struct diffstat_t diffstat; - diffstat = xcalloc(sizeof (struct diffstat_t), 1); - diffstat->xm.consume = diffstat_consume; + memset(&diffstat, 0, sizeof(struct diffstat_t)); + diffstat.xm.consume = diffstat_consume; for (i = 0; i < q->nr; i++) { struct diff_filepair *p = q->queue[i]; if (check_pair_status(p)) - diff_flush_stat(p, options, diffstat); + diff_flush_stat(p, options, &diffstat); } - show_stats(diffstat); - free(diffstat); + show_stats(&diffstat); } if (output_format & DIFF_FORMAT_SUMMARY) { -- 1.4.1.rc1.g5472-dirty