From: Pavel Roskin Date: Wed, 07 Jun 2006 17:01:40 GMT Subject: [PATCH] Off-by-one error in get_path_prefix(), found by Valgrind Message-ID: <20060607170140.13372.64613.stgit@dv.roinet.com> From: Pavel Roskin Signed-off-by: Pavel Roskin --- builtin-tar-tree.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-tar-tree.c b/builtin-tar-tree.c index 5f740cf..05da1f2 100644 --- a/builtin-tar-tree.c +++ b/builtin-tar-tree.c @@ -166,8 +166,8 @@ static unsigned int ustar_header_chksum( static int get_path_prefix(const struct strbuf *path, int maxlen) { int i = path->len; - if (i > maxlen) - i = maxlen; + if (i >= maxlen) + i = maxlen - 1; while (i > 0 && path->buf[i] != '/') i--; return i;