From: Horst von Brand Date: Tue, 06 Jun 2006 21:24:53 GMT Subject: Re: [PATCH] Cleanup git-send-email.perl:extract_valid_email Message-ID: <200606062124.k56LOroI007738@laptop11.inf.utfsm.cl> In-Reply-To: Junio C Hamano wrote: > Horst von Brand writes: > > Junio C Hamano wrote: > >> but I am > >> inclined to do this instead: > >> > >> my $domain_regexp = '[^.<>"\s@]+(?:\.[^.<>"\s@]+)+'; > >> > >> (i.e. still require at least two levels). > > > > OK, but be careful as this (?:...) is an extended regexp (needs /x on > > match). > Are you sure about /x? The manual (perlop(1)) says you need /x to match extended regexps, and (?...) is the marker for such (perlre(1)). But my perl here (5.5.8-6 on Fedora rawhide) doesn't care... -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513