From: Ralf Baechle <ralf@linux-mips.org>
Date: Sun, 26 Mar 2006 11:09:35 GMT
Subject: Re: Use a *real* built-in diff generator
Message-ID: <20060326110934.GA3774@linux-mips.org>
In-Reply-To: <Pine.LNX.4.64.0603251030340.15714@g5.osdl.org>

On Sat, Mar 25, 2006 at 10:39:03AM -0800, Linus Torvalds wrote:

> Besides, I hate how GNU patch bends over backwards in applying crap that 
> isn't a proper patch at all (whitespace-corruption, you name it: GNU patch 
> will accept it). Also, I made "git-apply" be all-or-nothing: either it 
> applies the _whole_ patch (across many different files) or it applies none 
> of it. With GNU patch, if you get an error on the fifth file, the four 
> first files have been modified already - aarrgghhh..

Which is apply's greatest strength - and weakness.  GNU diff doesn't
understand the file renamings bits of git diffs, so they they need to be
used with apply.  So if a patch doesn't apply?  Apply doesn't even have
an option to apply things as good as it can and leave the rest in
reject files.  Yuck.

  Ralf