From: Petr Baudis Date: Sun, 19 Mar 2006 21:29:11 GMT Subject: Re: [PATCH] ls-files: Don't require exclude files to end with a newline. Message-ID: <20060319212911.GD18185@pasky.or.cz> In-Reply-To: <8764mccaji.fsf@wine.dyndns.org> Dear diary, on Sat, Mar 18, 2006 at 11:27:45AM CET, I got a letter where Alexandre Julliard said that... > Without this patch, the last line of an exclude file is silently > ignored if it doesn't end with a newline. > > Signed-off-by: Alexandre Julliard $ echo -en "a\nb" | wc -l 1 In UNIX, a line is a string terminated by a newline, therefore the blob past the last newline character is not really a line at all. ;-) Perhaps a warning might be in order. Why don't you just add the trailing newline to the file? -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Right now I am having amnesia and deja-vu at the same time. I think I have forgotten this before.