From: Timo Hirvonen <tihirvon@gmail.com>
Date: Sun, 12 Mar 2006 15:13:16 GMT
Subject: Re: [PATCH] Use explicit pointers for execl...() sentinels.
Message-ID: <20060312171316.39d138f8.tihirvon@gmail.com>
In-Reply-To: <slrne18aae.fr9.mdw@metalzone.distorted.org.uk>

On Sun, 12 Mar 2006 13:59:42 +0000 (UTC)
Mark Wooding <mdw@distorted.org.uk> wrote:

> A terminator of `0' (or `NULL', which might well expand to `0') gets
> passed as type `int' in the absence of argument type declarations (which
> is the case for execl...(), since it uses varargs).  Argument passing
> conventions may differ between `int' and `char *' if, say, `int' is 32
> bits and pointers a 64; and there's no particular guarantee that a null
> pointer has all-bits-zero anyway.

NULL should always be ((void *)0).  What 64-bit systems declare NULL as
plain 0 (not 0L)?  How about fixing those systems instead of making the
git source code unreadable.

-- 
http://onion.dynserv.net/~timo/