From: Alex Riesen Date: Sun, 19 Feb 2006 18:39:30 GMT Subject: Re: [PATCH] git-rev-list --help anywhere Message-ID: <20060219183930.GB10010@steel.home> In-Reply-To: <20060219112627.18989.qmail@science.horizon.com> linux@horizon.com, Sun, Feb 19, 2006 12:26:27 +0100: > >+ for (i = 1 ; i < argc; i++) > >+ if ( !strcmp(argv[i], "--help") ) > >+ usage(rev_list_usage); > > You might want to try something more like: > > + for (i = 1 ; i < argc; i++) { > + if ( !strcmp(argv[i], "--help") ) > + usage(rev_list_usage); > + if ( !strcmp(argv[i], "--") ) > + break; > + } > > So that you don't break in the perverse but legal case of > having a file named "--help". Of course. Thanks! Signed-off-by: Alex Riesen --- diff --git a/rev-list.c b/rev-list.c index f2d1105..bcb492e 100644 --- a/rev-list.c +++ b/rev-list.c @@ -755,11 +755,20 @@ static void handle_all(struct commit_lis int main(int argc, const char **argv) { - const char *prefix = setup_git_directory(); + const char *prefix; struct commit_list *list = NULL; int i, limited = 0; for (i = 1 ; i < argc; i++) { + if ( !strcmp(argv[i], "--help") ) + usage(rev_list_usage); + if ( !strcmp(argv[i], "--") ) + break; + } + + prefix = setup_git_directory(); + + for (i = 1 ; i < argc; i++) { int flags; const char *arg = argv[i]; char *dotdot; -- 1.2.2.gbc57