From: Mark Wooding Date: Fri, 03 Feb 2006 20:27:02 GMT Subject: [PATCH 1/3] daemon: Provide missing argument for logerror() call. Message-ID: <20060203202702.1895.98868.stgit@metalzone.distorted.org.uk> In-Reply-To: <20060203202330.1895.60474.stgit@metalzone.distorted.org.uk> From: Mark Wooding Could cause a crash if --base-path set. Unlikely to be a security the concern: message doesn't go to the client, so we can't leak anything (except by dumping core), and we've already forked, so it's not a denial of service. Signed-off-by: Mark Wooding --- daemon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon.c b/daemon.c index bb014fa..532bb0c 100644 --- a/daemon.c +++ b/daemon.c @@ -147,7 +147,7 @@ static char *path_ok(char *dir) static char rpath[PATH_MAX]; if (*dir != '/') { /* Forbid possible base-path evasion using ~paths. */ - logerror("'%s': Non-absolute path denied (base-path active)"); + logerror("'%s': Non-absolute path denied (base-path active)", dir); return NULL; } snprintf(rpath, PATH_MAX, "%s%s", base_path, dir);