From: Alex Riesen <raa.lkml@gmail.com>
Date: Sat, 07 Jan 2006 09:25:38 GMT
Subject: Re: Use testlib to skip t3300-funny-names
Message-ID: <20060107092538.GA5536@steel.home>
In-Reply-To: <7vvewxq8xg.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano, Fri, Jan 06, 2006 23:38:03 +0100:
> > The test cannot be run on cygwin anyway.
> > Corrected the error message to reflect the problem source.
> 
> I'd rather see the test actually try to create a funny-named
> testfile and see if it managed to create it, so that it can be
> skipped on non DOS systems that mounted DOS filesystem.
> 
> So instead I would do something like this:
> 
> +test -f "$p1" && cmp "$p0" "$p1" || {
> +	# since FAT/NTFS does not allow tabs in filenames, skip this test
> +	say 'Your filesystem does not allow tabs in filenames, test skipped.'
> +	test_done
> +}

Yes, that's better