From: Timo Hirvonen <tihirvon@gmail.com>
Date: Sun, 18 Dec 2005 20:18:00 GMT
Subject: Re: [PATCH] git-grep: convert from bash to sh
Message-ID: <20051218221800.744e4565.tihirvon@gmail.com>
In-Reply-To: <Pine.LNX.4.64.0512181155360.4827@g5.osdl.org>

On Sun, 18 Dec 2005 11:57:26 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:

> On Sun, 18 Dec 2005, Timo Hirvonen wrote:
> > 
> > sh does not support arrays so we have to use eval instead.
> 
> This seems horribly broken.
> 
> If I'm not mistaken, this breaks
> 
> 	git grep "it's a happy coincidence"
> 
> badly. I didn't test, just looking at the patch.

Actually it works:

/usr/src/linux-2.6: git grep "it's a"
Documentation/Changes:debugfs.  Obviously, it's a good idea to upgrade.
Documentation/CodingStyle:and NOT read it.  Burn them, it's a great
symbolic gesture.


but it doesn't work with backslashes.  Need to use \\

/usr/src/linux-2.6: git grep 'e.\\n"'
Documentation/DMA-mapping.txt:		       "mydev: No suitable DMA
available.\n");
Documentation/DMA-mapping.txt:		       "mydev: No suitable DMA
available.\n");

-- 
http://onion.dynserv.net/~timo/