From: Amos Waterland Date: Wed, 14 Dec 2005 21:44:24 GMT Subject: Re: [PATCH] Do not ignore errors during make check Message-ID: <20051214214424.GA3730@kvasir.watson.ibm.com> In-Reply-To: <7v1x0fxt7b.fsf@assigned-by-dhcp.cox.net> On Wed, Dec 14, 2005 at 01:30:16PM -0800, Junio C Hamano wrote: > Good point but "|| exit" would be more appropriate. With the > above patch, I suspect "make check" merely stops at the first > error but resulting return code would still be zero, wouldn't > it? Yes, here is a patch that uses exit instead of break. --- Do not let errors pass by unnoticed when running `make check'. Signed-off-by: Amos Waterland --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) bc721e2d99487c0240514a848ac1cb84c086e008 diff --git a/Makefile b/Makefile index 01b6643..d494ad4 100644 --- a/Makefile +++ b/Makefile @@ -449,7 +449,7 @@ test-delta$X: test-delta.c diff-delta.o $(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $^ check: - for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i; done + for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done -- 0.99.9.GIT