From: Petr Baudis <pasky@suse.cz>
Date: Sun, 11 Dec 2005 00:11:06 GMT
Subject: Re: Latest cogito broken with bash-3.1
Message-ID: <20051211001106.GV22159@pasky.or.cz>
In-Reply-To: <1134220724.15125.4.camel@blade>

  Hello,

Dear diary, on Sat, Dec 10, 2005 at 02:18:44PM CET, I got a letter
where Marcel Holtmann <marcel@holtmann.org> said that...
> The cogito is the latest from kernel.org and when calling cg-commit it
> fails with this message:
> 
> cg-commit: line 200: syntax error near unexpected token `('
> cg-commit: line 200: `       eval commitfiles=($(cat $filter | path_xargs git-diff-index -r -m HEAD -- | \'
> 
> I played a little bit with it and it seems all the eval statements are
> broken with this bash version. I have no clue how to fix this, but maybe
> you do.

  it seems like the newer bash is stricter than the older versions in
some obscure regards. Quoting the eval arguments (which is the proper
thing to do anyway) fixed that particular problem; I've hit another
problem during a test commit wrt. whitespace separators - I've fixed
that too, and pushed out.

  Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.