From: Sven Verdoolaege <skimo@kotnet.org>
Date: Thu, 01 Dec 2005 13:51:13 GMT
Subject: Re: minor problems in git.c
Message-ID: <20051201135113.GW8383MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <81b0412b0512010448u7fcdddacnd7de5df217ab3ca@mail.gmail.com>

On Thu, Dec 01, 2005 at 01:48:35PM +0100, Alex Riesen wrote:
> @@ -283,16 +283,15 @@ int main(int argc, char **argv, char **e
>  	len = strlen(git_command);
>  	prepend_to_path(git_command, len);
>  
> -	strncat(&git_command[len], "/git-", sizeof(git_command) - len);
> -	len += 5;
> -	strncat(&git_command[len], argv[i], sizeof(git_command) - len);
> +	snprintf(git_command + len, sizeof(git_command) - len, "/git-%s",
> +		 argv[i]);

Shouldn't you check the return value of snprintf

>  	if (access(git_command, X_OK))
>  		usage(exec_path, "'%s' is not a git-command", argv[i]);

or use the (possibly) truncated version of the command in the error message ?

skimo