From: Eric Wong <normalperson@yhbt.net>
Date: Sun, 27 Nov 2005 05:43:33 GMT
Subject: Re: [PATCH 7/9] Add the accurate changeset applyer
Message-ID: <20051127054333.GA4707@mail.yhbt.net>
In-Reply-To: <46a038f90511262024g4eca7dc2oa42d1f72febf9e27@mail.gmail.com>

Martin Langhoff <martin.langhoff@gmail.com> wrote:
> On 11/24/05, Eric Wong <normalperson@yhbt.net> wrote:
> > And make it the default.
> 
> Cheeky, but right ;-)
> 
> Would it be a good idea to read the log entry and decide what kind of
> smarts do we need to apply the changeset? If the log entry looks
> plain, use process_patchset_fast(), else invoke $TLA?

This could work.  For it to work efficiently, process_patchset_fast()
should probably be modified to work on real Arch trees and rsync with
the git one.  Basically, we can replace the bulk of the tla replay calls
with your fast changeset applier.   Once the fast mode hits a changeset
it can't handle, it can do a tla replay on a single changeset instead of
having to do a slow get/apply-delta on an out-of-date tree.

process_patchset_fast() must understand how to handle permissions
changes, though, as Arch log entries are completely useless for that.

Unfortunately, doing this right and fast probably still requires more
time than it's worth.  Let's face it, trees with 12k files are extremely
rare in the Arch world (as are trees constantly reorganized by
obsessive-compulsives :), but many trees do get a small handful of
directory renames in their lifetime.

-- 
Eric Wong