From: Ryan Anderson <ryan@michonline.com>
Date: Wed, 23 Nov 2005 13:56:04 GMT
Subject: Re: [PATCH] git-mv is not able to handle big directories
Message-ID: <20051123135604.GB16995@mythryan2.michonline.com>
In-Reply-To: <7vu0e369p4.fsf@assigned-by-dhcp.cox.net>

On Wed, Nov 23, 2005 at 12:37:59AM -0800, Junio C Hamano wrote:
> merlyn@stonehenge.com (Randal L. Schwartz) writes:
> 
> >>>>>> "Junio" == Junio C Hamano <junkio@cox.net> writes:
> >
> > Junio>             open my $oh, qw(|- git-update-index -z --stdin)
> > Junio>                     or die "oops";
> >
> > This is Perl 5.6 or later.  Breaks on Perl 5.5, which is still in use
> > in some places.
> 
> I should have known better than posting Perl code to the list
> where a real guru is lurking and making afool of myself ;-).
> 
> Thanks for the advice.  How much do we care about 5.5?  IOW, is
> "in some places" wide enough to matter?
> 
> git-cvsimport, git-svnimport and git-shortlog share the same
> problem (svnimport declares that it wants 5.8).  perl58delta.pod
> does say list form of open for pipes is new in that version.  So
> what I wrote above requires 5.8 or better, perhaps?  cvsimport
> uses that same structure.  That is doubly Ouch.

No, you're not using the list form for pipes.  I use that in
git-graft-ripple:

	open(P,"-|","git-rev-list","--parents","--merge-order",$range)

For the kernel, requiring 5.8 shouldn't be a big issue. I suspect it's
really only the commercial Unixes where requiring 5.8 would be annoying.

Randal, is my guess even remotely accurate?

-- 

Ryan Anderson
  sometimes Pug Majere