From: Chris Wright Date: Sat, 12 Nov 2005 01:26:12 GMT Subject: Re: git-core-arch: Missing dependency Message-ID: <20051112012612.GD5856@shell0.pdx.osdl.net> In-Reply-To: <43754083.4090501@zytor.com> * H. Peter Anvin (hpa@zytor.com) wrote: > Junio C Hamano wrote: > >Andreas Ericsson writes: > >>Just to be anal; > >>Requires doesn't usually include the %release,... > > > >Obviously both you and Chris (who did the part you are quoting > >for us) know RPM spec a lot better than I do, and I see two > >experts contradicting with each other. It could have been just > >an oversight, or it might have done deliberately --- I cannot > >judge myself, so I punt here. I'll remove "-%{release}" when I > >hear Chris says he agrees with you. > > You can do it either way. It's a matter of the strictness of the > binding. If you put %{version} there, then it has to come from the same > upstream release; for %{version}-%{release} it has to come from the same > SRPM, i.e. usually from the same build. > > In this case I think %{version}-%{release} is appropriate. Yeah, I was being conservative. In reality, the release is rarely bumped, so it's probably not critical either way. thanks, -chris