From: Petr Baudis Date: Fri, 21 Oct 2005 12:47:11 GMT Subject: Re: [PATCH] cg-fetch: retrieve missing commits with a smarter optimization Message-ID: <20051021124711.GG30889@pasky.or.cz> In-Reply-To: <11298726913836-git-send-email-martin@catalyst.net.nz> Could you please resend your patches signed off? Thanks. Dear diary, on Fri, Oct 21, 2005 at 07:31:31AM CEST, I got a letter where Martin Langhoff told me that... > + will check tagrefs, trying to ensure it actually has the relevant > commits. If the commits are missing, it'll go out and fetch them. I'd prefer the approach to throw away the tag. Otherwise we get into problems when we want to grab only a single branch from multi-branch repository. > + if the tagref points to a blob and we have it, it'll skip it The problem is that the ^{blob} syntax is not in 0.98, so this would make Cogito depend on a yet unreleased GIT version, which is troublesome. So I guess this patch will end up in my post-0.99/1.0 queue for now. But by that time, this part of cg-fetch will be probably already totally rewritten. ;-) > This isn't a complete solution for cg-fetch -- git-fetch is actually > much smarter now, and cg-fetch should perhaps be a thin wrapper > around it, dropping all the duplicate code. I'm still thinking about it. I will certainly try to at least somehow reuse git-fetch's remote parser, if not anything else - reimplementing that would be just stupid. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ VI has two modes: the one in which it beeps and the one in which it doesn't.