From: Paolo 'Blaisorblade' Giarrusso Date: Sun, 09 Oct 2005 18:12:56 GMT Subject: [PATCH 2/2] git-verify-tag: detect wrong syntax Message-ID: <20051009181256.17885.6626.stgit@zion.home.lan> In-Reply-To: <20051009181246.17885.81654.stgit@zion.home.lan> From: Paolo 'Blaisorblade' Giarrusso Print proper error messages when failing, and handle -h/--help to avoid, if possible, to print double error message (from git-cat-file and from git-verify-tag). Signed-off-by: Paolo 'Blaisorblade' Giarrusso --- git-verify-tag.sh | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/git-verify-tag.sh b/git-verify-tag.sh --- a/git-verify-tag.sh +++ b/git-verify-tag.sh @@ -1,9 +1,16 @@ #!/bin/sh . git-sh-setup || die "Not a git archive" +usage() { + die "usage: git-verify-tag " +} + +[ $# = 1 ] || usage +[ "$1" = "-h" -o "$1" = "--help" ] && usage + tag=$(git-rev-parse $1) || exit 1 -type=$(git-cat-file -t $tag) || exit 1 +type=$(git-cat-file -t $tag) || usage [ "$type" = "commit" ] && die "Light tag - verification impossible" [ "$type" = "tag" ] || die "Bad tag - SHA1 doesn't refer to a tag object nor to a commit one."