From: Alex Riesen Date: Fri, 07 Oct 2005 21:39:52 GMT Subject: Re: First cut at git port to Cygwin Message-ID: <20051007213952.GA8821@steel.home> In-Reply-To: <4346E8AC.5030503@citi.umich.edu> Chuck Lever, Fri, Oct 07, 2005 23:29:16 +0200: > s/malloc/xmalloc/ It's not that funny after second repost... --- Make read_cache copy the index into memory, to improve portability on other OS's which have mmap too, tend to use it less commonly. Signed-off-by: Alex Riesen diff --git a/read-cache.c b/read-cache.c --- a/read-cache.c +++ b/read-cache.c @@ -497,9 +497,12 @@ int read_cache(void) offset = sizeof(*hdr); for (i = 0; i < active_nr; i++) { struct cache_entry *ce = map + offset; - offset = offset + ce_size(ce); - active_cache[i] = ce; + size_t size = ce_size(ce); + struct cache_entry *newce = xmalloc(size); + offset = offset + size; + active_cache[i] = memcpy(newce, ce, size); } + munmap(map, size); return active_nr; unmap: