From: Sergey Vlasov Date: Wed, 21 Sep 2005 16:19:09 GMT Subject: [PATCH 8/8] fetch.c: Remove call to parse_object() from process() Message-ID: <20050921161909.C39C5E2FFC7@center4.mivlgu.local> In-Reply-To: <20050921161829.GA20944@master.mivlgu.local> The call to parse_object() in process() is not actually needed - if the object type is unknown, parse_object() will be called by loop(); if the type is known, the object will be parsed by the appropriate process_*() function. After this change blobs which exist locally are no longer parsed, which gives about 2x CPU usage improvement; the downside is that there will be no warnings for existing corrupted blobs, but detecting such corruption is the job of git-fsck-objects, not the fetch programs. Newly fetched objects are still checked for corruption in http-fetch.c and ssh-fetch.c (local-fetch.c does not seem to do it, but the removed parse_object() call would not be reached for new objects anyway). --- fetch.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) b8a4d51743787be17f9572dce2eb2f4040ac241b diff --git a/fetch.c b/fetch.c --- a/fetch.c +++ b/fetch.c @@ -134,7 +134,6 @@ static int process(struct object *obj) obj->flags |= SEEN; if (has_sha1_file(obj->sha1)) { - parse_object(obj->sha1); /* We already have it, so we should scan it now. */ obj->flags |= TO_SCAN; } else {