From: Sergey Vlasov Date: Wed, 21 Sep 2005 16:19:03 GMT Subject: [PATCH 5/8] fetch.c: Remove some duplicated code in process() Message-ID: <20050921161903.AC3D2E2FFC8@center4.mivlgu.local> In-Reply-To: <20050921161829.GA20944@master.mivlgu.local> It does not matter if we call prefetch() or set the TO_SCAN flag before or after adding the object to process_queue. However, doing it before object_list_insert() allows us to kill 3 lines of duplicated code. --- fetch.c | 13 +++++-------- 1 files changed, 5 insertions(+), 8 deletions(-) dc255341f62596b0808c383ef8f3eff044be5515 diff --git a/fetch.c b/fetch.c --- a/fetch.c +++ b/fetch.c @@ -138,18 +138,15 @@ static int process(struct object *obj) /* We already have it, so we should scan it now. */ if (obj->flags & TO_SCAN) return 0; - object_list_insert(obj, process_queue_end); - process_queue_end = &(*process_queue_end)->next; obj->flags |= TO_SCAN; - return 0; + } else { + if (obj->flags & COMPLETE) + return 0; + prefetch(obj->sha1); } - if (obj->flags & COMPLETE) - return 0; + object_list_insert(obj, process_queue_end); process_queue_end = &(*process_queue_end)->next; - - prefetch(obj->sha1); - return 0; }