From: Petr Baudis Date: Wed, 21 Sep 2005 10:00:40 GMT Subject: Re: [PATCH 6/8] cogito: Don't ever assume object type in cg-object-id Message-ID: <20050921100040.GE24902@pasky.or.cz> In-Reply-To: <1127183120.31115.34.camel@dv> Dear diary, on Tue, Sep 20, 2005 at 04:25:20AM CEST, I got a letter where Pavel Roskin told me that... > Don't ever assume object type in cg-object-id. > > If type is unknown in normalize_id(), make it empty so it's checked > later. Check parent ID that it's a commit. Why? In most of the cases, you have one pointless fork() more, and we "assume" only if it was in a parent line, and if that's not a commit, you've got a *serious* problem with your database. fsck should yell you to death, and I don't think you could even normally commit such a commit, so this should never happen. There's no point in wasting time trying to handle seriously messed up database. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ VI has two modes: the one in which it beeps and the one in which it doesn't.