From: Petr Baudis Date: Tue, 20 Sep 2005 19:36:06 GMT Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs Message-ID: <20050920193606.GD28621@pasky.or.cz> In-Reply-To: <46a038f905091921154a70123f@mail.gmail.com> Dear diary, on Tue, Aug 30, 2005 at 12:00:10PM CEST, I got a letter where Martin Langhoff told me that... > Calls to cg-diff without filename parameters were dependent on GNU xargs > traits. BSD xargs is hardcoded to do --no-run-if-empty -- so if the filter > is effectively empty we avoid calling xargs. > > Signed-off-by: Martin Langhoff Thanks, I've applied it and also fixed the second git-diff-tree usage. Dear diary, on Tue, Sep 20, 2005 at 06:15:28AM CEST, I got a letter where Martin Langhoff told me that... > We still have a bug in cg-diff when using the BSD xargs. I posted a > fix, and Junio posted an alternative approach. The original patches > are here http://marc.theaimsgroup.com/?l=git&m=112541165904627&w=2 Looks like I've overlooked it in my fast Cogito patch scan. There are still parts of mailing list history in late August and early September that I didn't read. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ VI has two modes: the one in which it beeps and the one in which it doesn't.