From: Sven Verdoolaege Date: Mon, 19 Sep 2005 12:42:22 GMT Subject: Re: sprintf security holes? Message-ID: <20050919124222.GD15165MdfPADPa@greensroom.kotnet.org> In-Reply-To: <7voe6pv6zz.fsf@assigned-by-dhcp.cox.net> On Mon, Sep 19, 2005 at 12:42:08AM -0700, Junio C Hamano wrote: > We _might_ be protected from buffer overrun errors [*1*], but we > would then end up operating on a truncated data -- which would > lead to an equally unexpected behaviour. I do not think there > is any guarantee that working with unexpectedly truncated data > leads to less severe security problems than buffer overruns with > careless sprintf(). But you can _check_ whether the data has been truncated. Just look at the return value of snprintf. skimo