From: Wolfgang Denk Date: Sun, 24 Jul 2005 17:50:18 GMT Subject: Re: Should cg-mkpatch output be usable with cg-patch? Message-ID: <20050724175018.3D721352B73@atlas.denx.de> In-Reply-To: <20050722210352.GG11916@pasky.ji.cz> In message <20050722210352.GG11916@pasky.ji.cz> you wrote: > > > I wander what I should do with "cg-mkpatch" generated output; I had > > the impression that this should be usable with "cg-patch", but these > > are incompatible with each other. > > They certainly aren't. Is this a problem with the current implementation, or intentional? > > diff --git a/tools/img2brec.sh b/tools/img2brec.sh > > old mode 100644 > > new mode 100755 > > ... > > If I feed this into "cg-patch", I get: > > patch: **** Only garbage was found in the patch input. > > And did the changes apply? :-) No, they did not. No file modes were changed. > The message is surely confusing, but appeared to be rather corner-casy > and after I imagined the required complexity of filtering this, I > decided to spend my time on something more useful for the time being. :) I don't think this is a corner case. I think it is pretty important to be able to promote permissiong changes. Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Too many people are ready to carry the stool when the piano needs to be moved.