From: Petr Baudis <pasky@ucw.cz>
Date: Mon, 30 May 2005 00:32:42 GMT
Subject: Re: Problem with cg-diff <file>
Message-ID: <20050530003242.GA1036@pasky.ji.cz>
In-Reply-To: <7vis11ftvm.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Mon, May 30, 2005 at 02:19:09AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> >>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:
> 
> PB> ... git-diff-tree (in contrast to
> PB> git-diff-cache) won't take the pathspec as its trailing arguments,
> 
> PB> Junio, is there any specific reason for that, or is the end of
> PB> git-diff-tree argument list the right spot for the pathspec stuff?
> 
> Baffled.  Are you at Linus tip?
> 
> Linus correctly decided that diff-tree does not have to call
> diffcore_pathspec(), which may be what confused you to make the
> comment "... in contrast to git-diff-cache) won't take ...".
> But it does not call it only because it does not need to.  It
> filters the filepairs itself on the input side using the
> trailing arguments; since diffcore_pathspec filters as the first
> one in the chain as the input filter, calling it from diff-tree
> would not cull anything further.

Ok, so this is what you get when you mix: sleepiness, performing only
mental experiments not verified in practice, and inattentive reading of
the code.

I'm sorry for bothering. Instruct yourself from my bad example, please.
:-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor