From: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
Date: Sun, 22 May 2005 22:07:34 GMT
Subject: Re: Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFS
Message-ID: <20050522220734.GF23388@cip.informatik.uni-erlangen.de>
In-Reply-To: <Pine.LNX.4.58.0505221451590.2307@ppc970.osdl.org>

Hello,

> This is _really_ Linux-specific afaik. Which is ok for git, but at the
> same time it really makes me go "Ewww". It's testing that the major number 
> is 0, and it would be a lot more cleaner to use 

> 	if (!major(st.st_dev))

> but even that is very Linux-specific.

I see.

> I'll have to think about it. Maybe I should just remove the st_dev check. 
> I guess inode/size/mtime/ctime should be plenty safe enough in practice.

I think so. At least I kick this one out because it is just getting on
my nerves. :-)

	Thomas