From: Petr Baudis Date: Sun, 08 May 2005 20:40:43 GMT Subject: Re: Commit template Message-ID: <20050508204043.GJ9495@pasky.ji.cz> In-Reply-To: <1115584617.8949.51.camel@pegasus> Dear diary, on Sun, May 08, 2005 at 10:36:57PM CEST, I got a letter where Marcel Holtmann told me that... > Hi Petr, > > > > > my argument is; not to mess up with the CG: lines created by cg-commit. > > > > If you wanna insert a warning then you can of course add additional CG: > > > > lines to the commit template. > > > > > > Well, i'd argue that anyone making their own commit should be responsible > > > for making it look however they like. Maybe they want to only use only 60 > > > character wide lines and are tired of seeing the notice about CG: being > > > ignored. Gives the power user a tad more flexibility. But I really > > > don't care much either way. > > > > I'm with Sean on this one - implemented (with current cg-commit, and I > > used .git/commit-template file instead), committed, pushed out. > > then please do a "touch .git/commit-template" and call cg-commit. Now > you will see what I mean. It is too easy to screw up. So don't touch .git/commit-template. It's not like it stops working, you just don't get the top stuff. Which you probably wanted, why would you touch .git/commit-template otherwise? > Why not leave the list of modified files in the hand of the cg-commit > and people that wanna extra text inside their commit-template add > something like: > > CG: --- > CG: This is my testing tree, don't commit > > This will look much prettier and gives people the same possibilities to > change everything. But you have extra stuff both before and after the list of modified files. > If you wanna make the modified files list into a full configurable > template, then I think you must introduce place holders. That's what I was thinking about, actually - @@MODIFIED@@ and such, and it replaces _all_ the CG: stuff. Just decided that I have better things to do now personally. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor