From: Greg KH Date: Fri, 06 May 2005 16:03:59 GMT Subject: Re: [PATCH] fix compare symlink against readlink not data Message-ID: <20050506160359.GB6904@kroah.com> In-Reply-To: <20050506134501.GA11430@vrfy.org> On Fri, May 06, 2005 at 03:45:01PM +0200, Kay Sievers wrote: > Fix update-cache to compare the blob of a symlink against the link-target > and not the file it points to. Also ignore all permissions applied to > links. > Thanks to Greg for recognizing this while he added our list of symlinks > back to the udev repository. Hm, even with this patch applied (it's in Linus's tree right now), I still get the following with a clean checked out udev tree: $ cg-diff Index: test/sys/block/cciss!c0d0/device =================================================================== Index: test/sys/block/rd!c0d0/device =================================================================== Index: test/sys/block/sda/device =================================================================== Index: test/sys/bus/pci/devices/0000:00:09.0 =================================================================== Index: test/sys/bus/pci/devices/0000:00:1e.0 =================================================================== Index: test/sys/bus/pci/devices/0000:02:05.0 =================================================================== Index: test/sys/bus/pci/drivers/aic7xxx/0000:02:05.0 =================================================================== Index: test/sys/bus/scsi/devices/0:0:0:0 =================================================================== Index: test/sys/bus/scsi/drivers/sd/0:0:0:0 =================================================================== Index: test/sys/bus/usb-serial/devices/ttyUSB0 =================================================================== Index: test/sys/bus/usb-serial/drivers/PL-2303/ttyUSB0 =================================================================== Index: test/sys/bus/usb/devices/3-0:1.0 =================================================================== Index: test/sys/bus/usb/devices/3-1 =================================================================== Index: test/sys/bus/usb/devices/3-1:1.0 =================================================================== Index: test/sys/bus/usb/devices/usb3 =================================================================== Index: test/sys/bus/usb/drivers/hub/3-0:1.0 =================================================================== Index: test/sys/bus/usb/drivers/pl2303/3-1:1.0 =================================================================== Index: test/sys/bus/usb/drivers/usb/3-1 =================================================================== Index: test/sys/bus/usb/drivers/usb/usb3 =================================================================== Index: test/sys/class/tty/ttyUSB0/device =================================================================== Index: test/sys/devices/pci0000:00/0000:00:09.0/usb3/3-1/ttyUSB0/driver =================================================================== Any idea? thanks, greg k-h