From: Petr Baudis Date: Sat, 16 Apr 2005 23:43:44 GMT Subject: Re: optimize gitdiff-do script Message-ID: <20050416234344.GQ19099@pasky.ji.cz> In-Reply-To: <20050416232810.23430.78712.sendpatchset@sam.engr.sgi.com> Dear diary, on Sun, Apr 17, 2005 at 01:28:04AM CEST, I got a letter where Paul Jackson told me that... > Reduce number of subcommands execv'd by a > third, by only calling 'rm' once, at end, not each > loop. The idea behind that was that diffing could take a significant portion of disk space, especially when making large kernel diffs. Perhaps we could make this a switch, but I would personally prefer defaulting to the less space-consuming behaviour. I personally dislike applications which like to pop 150M of nonsense to my /tmp. Please don't reindent the scripts. It violates the current coding style and the patch is unreviewable. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor