From: Shaoxuan Yuan Date: Thu, 04 Aug 2022 08:40:13 GMT Subject: Re: [PATCH v1 6/7] mv: from in-cone to out-of-cone Message-ID: <1fb0b736-280f-01bf-bb7c-48e8c9b060cb@gmail.com> In-Reply-To: On 7/20/2022 2:14 AM, Derrick Stolee wrote: >> +                if ((mode & INDEX) && is_empty_dir(src_dir)) >> +                    rmdir_or_warn(src_dir); > > This is an interesting cleanup of the first-level directory. Should it be > recursive and clean up an entire chain of paths? Indeed. I'm planning to use an array to record the possible `src_dir`, i.e. WORKING_DIRECTORYs in `git-mv`, and use a loop to cleanup the empty directories recursively. -- Thanks, Shaoxuan