From: Derrick Stolee via GitGitGadget Date: Fri, 05 Sep 2025 19:26:14 GMT Subject: [PATCH v3 2/6] midx-write: put failing response value back Message-ID: <1e5f43a417207e243a947d09255d71c26a52ef59.1757100378.git.gitgitgadget@gmail.com> In-Reply-To: From: Derrick Stolee This instance of setting the result to 1 before going to cleanup was accidentally removed in fcb2205b77 (midx: implement support for writing incremental MIDX chains, 2024-08-06). Build upon a test that already deletes a packfile to verify that this error propagates to full command failure. Signed-off-by: Derrick Stolee --- midx-write.c | 1 + t/t5319-multi-pack-index.sh | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/midx-write.c b/midx-write.c index 070a7f61f4..0f1d5653ab 100644 --- a/midx-write.c +++ b/midx-write.c @@ -1104,6 +1104,7 @@ static int write_midx_internal(struct repository *r, const char *object_dir, m = m->base_midx; } } else if (ctx.m && fill_packs_from_midx(&ctx)) { + result = 1; goto cleanup; } diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh index 49705c62a2..2c22fdb931 100755 --- a/t/t5319-multi-pack-index.sh +++ b/t/t5319-multi-pack-index.sh @@ -1100,7 +1100,10 @@ test_expect_success 'load reverse index when missing .idx, .pack' ' mv $idx.bak $idx && mv $pack $pack.bak && - git cat-file --batch-check="%(objectsize:disk)" err && + test_grep "could not load pack" err ) ' -- gitgitgadget