From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Thu, 27 Apr 2017 05:04:48 GMT
Subject: Re: [PATCH 39/53] refs/files-backend: convert many internals to struct object_id
Message-ID: <1e4a72a0-9b6c-e9b4-7639-d241558e2120@alum.mit.edu>
In-Reply-To: <20170423213453.253425-40-sandals@crustytoothpaste.net>

On 04/23/2017 11:34 PM, brian m. carlson wrote:
> Convert many of the internals of the files backend to use struct
> object_id.  Avoid converting public APIs to limit the scope of the
> changes.
> 
> Convert one use of get_sha1_hex to parse_oid_hex, and rely on the fact
> that a strbuf will be NUL-terminated and that parse_oid_hex will fail on
> truncated input to avoid the need to check for an explicit length.
> 
> This is a requirement to convert parse_object later on.
> [...]

This patch also looks fine to me.

Michael