From: Taylor Blau Date: Tue, 21 Apr 2026 20:37:51 GMT Subject: [PATCH v2 13/16] packfile: ensure `close_pack_revindex()` frees in-memory revindex Message-ID: <1e1b957bf1266cee1608981d1a2960d4577aec79.1776803827.git.me@ttaylorr.com> In-Reply-To: The following commit will introduce a case where we write a MIDX bitmap over packs that do not themselves have on-disk *.rev files. This case is supported within Git, and we will simply fall back to generating the revindex in memory. But we don't ever release that memory, causing a leak that is exposed by a test introduced in the following commit. (As far as I could find, we never free()'d memory allocated as a byproduct of creating an in-memory revindex, likely because that code predates the leak-checking niceties we have in the test suite now.) Rectify this by calling `FREE_AND_NULL()` on the `p->revindex` field when calling `close_pack_revindex()`. Signed-off-by: Taylor Blau --- packfile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packfile.c b/packfile.c index b012d648ada..a1e88fdb223 100644 --- a/packfile.c +++ b/packfile.c @@ -420,6 +420,8 @@ void close_pack_index(struct packed_git *p) static void close_pack_revindex(struct packed_git *p) { + FREE_AND_NULL(p->revindex); + if (!p->revindex_map) return; -- 2.54.0.9.gb905fd5d0ae