From: Dragan Simic <dsimic@manjaro.org>
Date: Sun, 21 Apr 2024 14:00:57 GMT
Subject: Re: [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive
Message-ID: <1d7ee11f801f2754529256bbf4570fd3@manjaro.org>
In-Reply-To: <xmqqo7a5mk8f.fsf@gitster.g>

On 2024-04-19 17:43, Junio C Hamano wrote:
> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> 
>> On Fri, Apr 19, 2024, at 03:05, Dragan Simic wrote:
>>> Fix a bug that allows the "--rfc" and "-k" options to be specified 
>>> together
>>> when "git format-patch" is executed, which was introduced in the 
>>> commit
>>> e0d7db7423a9 ("format-patch: --rfc honors what --subject-prefix 
>>> sets").
>>> 
>>> Add a couple of additional tests to t4014, to cover additional cases 
>>> of
>>> the mutual exclusivity between different "git format-patch" options.
>>> 
>>> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
>> 
>> Looks good to me FWIW. Also very good description of the changes from
>> the previous version to this one.
> 
> Yup, very easy to follow what changed and how.
> 
> Will queue, thanks all.

Thank you!