From: Ramsay Jones Date: Fri, 02 Mar 2018 02:54:02 GMT Subject: [PATCH 1/2] ref-filter: mark a file-local symbol as static Message-ID: <1d28d866-535c-6d37-4cb9-5decedab3acb@ramsayjones.plus.com> Commit fcfba37337 ('ref-filter: make "--contains " less chatty if is invalid', 2018-02-23) added the add_str_to_commit_list() function, which causes sparse to issue a "... not declared. Should it be static?" warning for that symbol. In order to suppress the warning, mark that function as static. Signed-off-by: Ramsay Jones --- ref-filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ref-filter.c b/ref-filter.c index f375e7670..69bf7b587 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -2000,7 +2000,7 @@ static void do_merge_filter(struct ref_filter_cbdata *ref_cbdata) free(to_clear); } -int add_str_to_commit_list(struct string_list_item *item, void *commit_list) +static int add_str_to_commit_list(struct string_list_item *item, void *commit_list) { struct object_id oid; struct commit *commit; -- 2.16.0