From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 03 Nov 2020 13:57:15 GMT
Subject: Re: [PATCH 2/4] push: teach --base for ssh:// and file://
Message-ID: <1ccd47dc-0470-39de-b26e-5e2f896bb0fe@gmail.com>
In-Reply-To: <148e39960a2185d2355cdfe34f8856e708fb1b80.1604362701.git.jonathantanmy@google.com>

On 11/2/2020 7:26 PM, Jonathan Tan wrote:
> For the ssh:// and file:// transports, teach push the "--base"
> parameter, which indicates an ancestor of the commits to be pushed that
> is believed to be known by the server.

Looking at this patch, I don't see any reason why this couldn't be
a multi-valued parameter that populates a string_list on the client
and the server translates into a list of object_ids. Converting from
the current single-base model to a multiple-base model would probably
be just as big of a patch as this one, so perhaps jump straight to
that capability instead of pausing at the single-base model here?

Thanks,
-Stolee