From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 04 Aug 2020 13:03:36 GMT
Subject: Re: [PATCH 10/10] builtin/commit-graph.c: introduce '--max-new-filters=<n>'
Message-ID: <1c2e841b-4b04-30ba-6c94-96f8bf0cf449@gmail.com>
In-Reply-To: <8b670571dc24973cc5e894b866a68236d8fbfa4f.1596480582.git.me@ttaylorr.com>

On 8/3/2020 2:57 PM, Taylor Blau wrote:
> Introduce a command-line flag and configuration variable to fill in the
> 'max_new_filters' variable introduced by the previous patch.
> 
> The command-line option '--max-new-filters' takes precedence over
> 'graph.maxNewFilters', which is the default value.

commitGraph.maxNewFilters?

> '--no-max-new-filters' can also be provided, which sets the value back
> to '-1', indicating that an unlimited number of new Bloom filters may be
> generated. (OPT_INTEGER only allows setting the '--no-' variant back to
> '0', hence a custom callback was used instead).

Other than the commit message typo above, this is a good patch.

Thanks,
-Stolee