From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 06 Jun 2024 06:39:17 GMT
Subject: Re: [PATCH v2 3/3] diff: let external diffs report that changes are uninteresting
Message-ID: <1c055e96-76b0-4174-a8e2-cb6df041fabf@kdbg.org>
In-Reply-To: <99a99e5c-4fe4-413a-9281-363e280716b8@web.de>

Am 05.06.24 um 10:38 schrieb René Scharfe:
> +diff.trustExitCode::
> +	If this boolean value is set to true then the `diff.external`
> +	command is expected to return exit code 1 if it finds
> +	significant changes and 0 if it doesn't, like diff(1).  If it's
> +	false then the `diff.external` command is expected to always
> +	return exit code 0.  Defaults to false.

I find this somewhat unclear. What are the consequences when this value
is set to false, but the command exits with code other than 0? Is it

    If it's false then any exit code other than 0 of the `diff.external`
    command is treated as an error.

-- Hannes