From: Derrick Stolee <derrickstolee@github.com>
Date: Thu, 23 Feb 2023 14:20:39 GMT
Subject: Re: [PATCH 12/16] object-store.h: move struct object_info from cache.h
Message-ID: <1bdd1b4f-ca8e-5790-ef24-7e289692a721@github.com>
In-Reply-To: <c42261483cff903c8742fd8e1423ac0b14c65099.1677139522.git.gitgitgadget@gmail.com>

On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
> 
> Move struct object_info, and a few related #define's from cache.h to
> object-store.h.

> diff --git a/replace-object.h b/replace-object.h
> index 3fbc32eb7b7..3c92ae94610 100644
> --- a/replace-object.h
> +++ b/replace-object.h
> @@ -1,6 +1,7 @@
>  #ifndef REPLACE_OBJECT_H
>  #define REPLACE_OBJECT_H
>  
> +#include "cache.h"
>  #include "oidmap.h"
>  #include "repository.h"
>  #include "object-store.h"

This seems like an unlikely side-effect of the changes you're
making. What is the reason we need this?

Thanks,
-Stolee